update mysql dependency version by mlsorensen · Pull Request #8753 · apache/cloudstack

mlsorensen · 2024-03-06T22:37:34Z

Description

This PR keeps us up to date on mysql-connector maven dependency.

Also fixing:

[WARNING] While downloading mysql:mysql-connector-java:8.0.33
  This artifact has been relocated to com.mysql:mysql-connector-j:8.0.33.
  MySQL Connector/J artifacts moved to reverse-DNS compliant Maven 2+ coordinates.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

codecov · 2024-03-06T22:45:59Z

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 30.64%. Comparing base (0208e09) to head (ca2a8d8).

Files	Patch %	Lines
...c/main/java/com/cloud/upgrade/DatabaseCreator.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8753      +/-   ##
============================================
- Coverage     30.91%   30.64%   -0.28%     
+ Complexity    34249    33893     -356     
============================================
  Files          5354     5354              
  Lines        376094   376096       +2     
  Branches      54696    54696              
============================================
- Hits         116258   115241    -1017     
- Misses       244542   245654    +1112     
+ Partials      15294    15201      -93

Flag	Coverage Δ
simulator-marvin-tests	`24.29% <50.00%> (-0.44%)`	⬇️
uitests	`4.39% <ø> (ø)`
unit-tests	`16.59% <75.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yadvr · 2024-03-07T02:33:36Z

@mlsorensen can you review the GitHub Actions failures?

@blueorangutan package

blueorangutan · 2024-03-07T02:34:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-07T03:44:55Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8868

yadvr · 2024-03-07T05:25:59Z

@mlsorensen PR LGTM, however, it's breaking the mvn deploydb:

========> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
22:48:25.067 [com.cloud.upgrade.DatabaseCreator.main()] ERROR com.cloud.utils.db.DbUtil - GET_LOCK() throws exception 
java.sql.SQLException: Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY.
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:130) ~[mysql-connector-j-8.0.33.jar:8.0.33]
	at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122) ~[mysql-connector-j-8.0.33.jar:8.0.33]

From release notes, it seems the driver has changed/assumed some new defaults in handling of cursor/resultset.

@blueorangutan test matrix

blueorangutan · 2024-03-07T05:28:04Z

@rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-03-07T05:46:42Z

[SF] Trillian Build Failed (tid-9413)

blueorangutan · 2024-03-07T05:46:56Z

[SF] Trillian Build Failed (tid-9415)

blueorangutan · 2024-03-07T05:49:30Z

[SF] Trillian Build Failed (tid-9414)

sureshanaparti · 2024-03-07T11:39:31Z

@mlsorensen PR LGTM, however, it's breaking the mvn deploydb:

========> Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker
22:48:25.067 [com.cloud.upgrade.DatabaseCreator.main()] ERROR com.cloud.utils.db.DbUtil - GET_LOCK() throws exception 
java.sql.SQLException: Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY.
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:130) ~[mysql-connector-j-8.0.33.jar:8.0.33]
	at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122) ~[mysql-connector-j-8.0.33.jar:8.0.33]

From release notes, it seems the driver has changed/assumed some new defaults in handling of cursor/resultset.

@blueorangutan test matrix

Hi @mlsorensen It works after adding "scrollTolerantForwardOnly=true" to the connection string. Please update the mysql connection strings.

References:
https://dev.mysql.com/doc/relnotes/connector-j/en/news-8-0-24.html
https://dev.mysql.com/doc/connector-j/en/connector-j-connp-props-result-sets.html#cj-conn-prop_scrollTolerantForwardOnly

A new connection property, [scrollTolerantForwardOnly](https://dev.mysql.com/doc/connector-j/en/connector-j-connp-props-result-sets.html#cj-conn-prop_scrollTolerantForwardOnly), has been introduced, which preserved the legacy behavior of Connector/J 8.0.17 and earlier by tolerating backward and absolute cursor movements on result sets of type ResultSet.TYPE_FORWARD_ONLY. This is for maintaining compatibility with legacy code that took advantage of the old behavior. See the description for [scrollTolerantForwardOnly](https://dev.mysql.com/doc/connector-j/en/connector-j-connp-props-result-sets.html#cj-conn-prop_scrollTolerantForwardOnly) for details. (Bug #31747910)

blueorangutan · 2024-03-07T11:40:03Z

@sureshanaparti a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-03-07T11:58:57Z

[SF] Trillian Build Failed (tid-9422)

blueorangutan · 2024-03-07T11:58:59Z

[SF] Trillian Build Failed (tid-9420)

blueorangutan · 2024-03-07T12:01:31Z

[SF] Trillian Build Failed (tid-9421)

mlsorensen · 2024-03-07T16:57:17Z

Thanks @sureshanaparti , updated per your recommendations. Also updating the poms to remove the warnings about outdated group id for mysql.

sureshanaparti · 2024-03-07T17:17:09Z

Thanks @sureshanaparti , updated per your recommendations. Also updating the poms to remove the warnings about outdated group id for mysql.

Thanks @mlsorensen

sureshanaparti · 2024-03-07T17:17:27Z

@blueorangutan package

blueorangutan · 2024-03-07T17:18:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-07T18:25:51Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8878

blueorangutan · 2024-03-08T22:55:17Z

[SF] Trillian test result (tid-9427)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51917 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8753-t9427-kvm-centos7.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_verify_ipv6_vpc	`Failure`	754.04	test_vpc_ipv6.py

yadvr · 2024-03-13T06:24:35Z

@mlsorensen can you rebase your PR branch to 4.19, since we have been using a really outdated dependency and this is a more secured improvement

github-actions · 2024-03-13T13:20:02Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sureshanaparti · 2024-03-13T17:03:29Z

@blueorangutan package

blueorangutan · 2024-03-13T17:04:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-13T18:07:29Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8926

weizhouapache · 2024-03-13T18:11:12Z

@blueorangutan test

blueorangutan · 2024-03-13T18:12:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

sureshanaparti

code lgtm

yadvr · 2024-03-14T07:06:06Z

@blueorangutan test ol8 kvm-ol8

blueorangutan · 2024-03-14T07:08:03Z

@rohityadavcloud [SL] unsupported parameters provided. Supported mgmt server os are: centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

yadvr · 2024-03-14T12:40:40Z

@blueorangutan test alma8 kvm-alma8

blueorangutan · 2024-03-14T12:42:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests

blueorangutan · 2024-03-15T02:02:47Z

[SF] Trillian test result (tid-9485)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 46007 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8753-t9485-kvm-alma8.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

yadvr · 2024-03-15T05:48:51Z

@blueorangutan test alma9 kvm-alma9

blueorangutan · 2024-03-15T05:50:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan · 2024-03-15T22:20:49Z

[SF] Trillian test result (tid-9490)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 57769 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8753-t9490-kvm-alma9.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

borisstoyanov

LGTM

Co-authored-by: Marcus Sorensen <mls@apple.com>

boring-cyborg Bot added the component:build label Mar 6, 2024

yadvr requested a review from sureshanaparti March 7, 2024 15:53

yadvr added this to the 20.0.0 milestone Mar 7, 2024

yadvr assigned sureshanaparti Mar 7, 2024

boring-cyborg Bot added component:database component:mysql component:networking component:primary-storage component:quota component:storage component:usage-server labels Mar 7, 2024

yadvr changed the base branch from main to 4.19 March 13, 2024 06:23

github-actions Bot added the status:has-conflicts label Mar 13, 2024

Update mysql-connector version

ca2a8d8

mlsorensen force-pushed the upstream-mysql-connector branch from 9265a61 to ca2a8d8 Compare March 13, 2024 16:37

boring-cyborg Bot added component:marvin Python Warning... Python code Ahead! labels Mar 13, 2024

github-actions Bot removed the status:has-conflicts label Mar 13, 2024

sureshanaparti approved these changes Mar 14, 2024

View reviewed changes

yadvr assigned borisstoyanov and unassigned sureshanaparti Mar 19, 2024

borisstoyanov approved these changes Mar 20, 2024

View reviewed changes

yadvr merged commit 2e88eb4 into apache:4.19 Mar 21, 2024

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 25, 2024

Update mysql-connector version (apache#8753)

d58a390

Co-authored-by: Marcus Sorensen <mls@apple.com>

sureshanaparti mentioned this pull request Apr 19, 2024

Update netty version for compatibility/staying current #8945

Merged

13 tasks

Uh oh!

Conversation

mlsorensen commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Uh oh!

codecov Bot commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yadvr commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

yadvr commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

sureshanaparti commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

mlsorensen commented Mar 7, 2024

Uh oh!

sureshanaparti commented Mar 7, 2024

Uh oh!

sureshanaparti commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 8, 2024

Uh oh!

yadvr commented Mar 13, 2024

Uh oh!

github-actions Bot commented Mar 13, 2024

Uh oh!

sureshanaparti commented Mar 13, 2024

Uh oh!

blueorangutan commented Mar 13, 2024

Uh oh!

blueorangutan commented Mar 13, 2024

Uh oh!

weizhouapache commented Mar 13, 2024

Uh oh!

blueorangutan commented Mar 13, 2024

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Mar 14, 2024

Uh oh!

blueorangutan commented Mar 14, 2024

Uh oh!

yadvr commented Mar 14, 2024

Uh oh!

blueorangutan commented Mar 14, 2024

Uh oh!

blueorangutan commented Mar 15, 2024

Uh oh!

yadvr commented Mar 15, 2024

mlsorensen commented Mar 6, 2024 •

edited

Loading

codecov Bot commented Mar 6, 2024 •

edited

Loading